support dart-lang

[r6m]

Currently Dart is not supported.

Is there any plans to support dart-lang as well?

[mhamrah]

No immediate plans, but happy to accept PR's.

[noltedennis]

Hi @mhamrah and @rezam90,

I encountered the same issue yesterday and decided to try and extend the project with DART support. Attached you can find a patch file. Since this is my first open source contribution I am hesistant to open a PR directly and would like to collect thoughts and feedback first.

For DART support, I had to undertake the following changes:

1. Change from Alpine-based image to Debian-Stretch based base-docker image, because the DART SDK afaik cannot be compiled with musl
2. Add the DART SDK and plugin to the image. For quickness I did not build these myself and instead used the available Debian packages.
3. With the change of the base image I had to swap out some dependenices
4. For DART we need to include the Google pre-defined stubs, because the DART protobuf package - unlike most other packages - does not include these.

Since we changed the base image and added the Dart SDK, the Docker image size trippled. Would you still be willing to go forward with this change?

Kind regards,
Dennis
add-dart-support.patch.txt

[mhamrah]

I'm no longer a maintainer on the project, but I'm sure someone will work with you.

…

On Sat, May 2, 2020, 4:59 AM noltedennis ***@***.***> wrote: Hi @mhamrah <https://github.com/mhamrah> and @rezam90 <https://github.com/rezam90>, I encountered the same issue yesterday and decided to try and extend the project with DART support. Attached you can find a patch file. Since this is my first open source contribution I am hesistant to open a PR directly and would like to collect thoughts and feedback first. For DART support, I had to undertake the following changes: 1. Change from Alpine-based image to Debian-Stretch based base-docker image, because the DART SDK afaik cannot be compiled with musl-ssl 2. Add the DART SDK and plugin to the image. For quickness I did not build these myself and instead used the available Debian packages. 3, With the change of the base image I had to swap out some dependenices 3. For DART we need to include the Google pre-defined stubs, because the DART protobuf packages - unlike most other packages - does not include these. Since we changed the base image and added the Dart SDK, the Docker image size trippled. Would you still be willing to go forward with this change? Kind regards, Dennis add-dart-support.patch.txt <https://github.com/namely/docker-protoc/files/4567344/add-dart-support.patch.txt> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#113 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAWIGQEVSV5DDIQYRLZW6DRPPOFVANCNFSM4G73ZNXA> .

[ido-namely]

Hi @noltedennis ,
Sorry for the late reply.
I don't know if you've lost interest in contributing, but I'm happy to review a PR if you submit it.
Since we switched to a debian based image since your last message, I don't think there should be any problems with the approach you've described.

[jcburley]

@r6m @noltedennis – please consider submitting a PR for this if you're still interested; else feel free to close it out. Thanks!