From 0e42d273f2a747909b7792fa965500118b3e0305 Mon Sep 17 00:00:00 2001 From: Steve Ognibene Date: Tue, 25 Jul 2023 10:42:24 -0400 Subject: [PATCH] Update default Node.js version to 18 (#377) * Update default Node.js version to 18 * remove unsafe perm - no longer supported this way in Node.js 18 default npm --- Dockerfile | 1 - variables.sh | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index bef68d00..c975902e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -153,7 +153,6 @@ RUN curl -fsSL "https://deb.nodesource.com/setup_${node_version}.x" | bash - RUN apt-get install -y nodejs # Add Node TypeScript support -RUN npm config set unsafe-perm true RUN npm i -g grpc_tools_node_protoc_ts@$node_grpc_tools_node_protoc_ts_version grpc-tools@$node_grpc_tools_version protoc-gen-grpc-web@$node_protoc_gen_grpc_web_version # Add TypeScript support diff --git a/variables.sh b/variables.sh index 6b4801dc..cffbc9e5 100755 --- a/variables.sh +++ b/variables.sh @@ -16,7 +16,7 @@ PROTOBUF_JS_VERSION=${PROTOBUF_JS_VERSION:-v3.21.2} UBER_PROTOTOOL_VERSION=${UBER_PROTOTOOL_VERSION:-1.10.0} SCALA_PB_VERSION=${SCALA_PB_VERSION:-0.11.0} MYPY_VERSION=${MYPY_VERSION:-3.4.0} -NODE_VERSION=${NODE_VERSION:-14} +NODE_VERSION=${NODE_VERSION:-18} NODE_GRPC_TOOLS_NODE_PROTOC_TS_VERSION=${NODE_GRPC_TOOLS_NODE_PROTOC_TS_VERSION:-5.3.2} NODE_GRPC_TOOLS_VERSION=${NODE_GRPC_TOOLS_VERSION:-1.12.3} NODE_PROTOC_GEN_GRPC_WEB_VERSION=${NODE_PROTOC_GEN_GRPC_WEB_VERSION:-1.4.1}