Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Email #1676

Open
fequesada opened this issue Nov 13, 2023 · 20 comments
Open

Notification Email #1676

fequesada opened this issue Nov 13, 2023 · 20 comments
Milestone

Comments

@fequesada
Copy link

Describe the solution you'd like
Notification for change account status.

Describe alternatives you've considered
How registration approval notification emails are sent, it could also be sent an email for an account status change.

Additional context

@FatihKoz
Copy link
Contributor

During registration members get notified about being accepted or rejected, no need to send notifications when a pilot record is deleted (as the e-mail record will be deleted too) so you will have "On Leave" and "Suspended" only. Are notifications are really necessary for these two, what will be the operational gain?

  • if someone is "On Leave" system will allow them to login and fly (which will automatically make them active again),
  • if someone is "Suspended" manually ('cause this is not automated) system will not allow them to even login and use your services.

These two can be configured of course, but we need to have an operational gain in them otherwise it will be just time spent on something not being used at all :)

Safe flights

@fequesada
Copy link
Author

I talked about the suggestion because sometimes we have to warn or suspend a pilot for some reason, and there isn't that possibility. We would have to wait for the person to contact us, and then explain the reason for such suspension or warning. And sometimes, we want to send an email to specific pilots about something they did wrong or forgot. But it was just a suggestion because, in my virtual airline, we already have almost 50 active pilots. That's why I said it would make things a lot easier.

Safe flights!

@nabeelio nabeelio added this to the 7.0.1 milestone Nov 22, 2023
@arthurpar06
Copy link
Contributor

Hi,
What do you think about sending emails to specific pilots from the admin interface? Similar to creating a news, you enter the subject, the content, then you choose your recipients and phpVMS sends the email for you.

@fequesada
Copy link
Author

No, if a pilot is warned, suspended, or banned, they receive an email notification. Captain X committed some infraction; we changed his status to suspended. He receives an email notifying him that he is suspended.

@FatihKoz
Copy link
Contributor

So you still want an autmated mail when a pilot gets suspended.

Because it is the only punishment you can give to a pilot.

@fequesada
Copy link
Author

That's it!

@arthurpar06
Copy link
Contributor

Okay, but then my question is, what does it really achieve?

Because a suspended pilot who tries to log in will see a message saying that they can't log in because they are suspended. If we send an email that just says "You are suspended," without explaining why the person will still contact you to ask for an explanation of their suspension.

@FatihKoz
Copy link
Contributor

Nothing will be achieved, it will be a mail sent out. That's it.

What can be done is maybe utilizing a field for administrative notes, (like remarks) make it visible in that email and also make it visible on login attempts.

Then it "maybe" can be useful.

@fequesada
Copy link
Author

Nothing will be achieved, it will be a mail sent out. That's it.

What can be done is maybe utilizing a field for administrative notes, (like remarks) make it visible in that email and also make it visible on login attempts.

Then it "maybe" can be useful.

Exactly, this would explain the reason for the suspension/ban, providing clarity on the matter. More specific matters will be discussed via Discord. Failure to respond may result in suspension.

@FatihKoz
Copy link
Contributor

User will be suspended when this happens. So your "failure to respond may result suspension" is not right :)

@arthurpar06
Copy link
Contributor

Okay, so I'm having trouble seeing why my solution doesn't suit you.

With yours the email is automatic, yes, but you still have to specify the reason for the suspension in a place that can serve other purposes or is not very explicit.

Sending the email by choosing the recipient from the admin and putting the reason for the suspension in it solves this problem by having something explicitly designed to do so (rather than something like: if someone is suspended one day and the "management notes" field is not empty, then we send an email with its content, which may have nothing to do with the suspension).

The other advantage of my solution is that it is also more general because it is a simple way to contact your pilots (hoping they don't try to reply to your no-reply address).

@FatihKoz
Copy link
Contributor

Either way, user will not be able to login, and will contact staff.

So that email will be really useless and not operational at all 😉

@FatihKoz
Copy link
Contributor

Another option, add a new state WARNING ... Put pilots to that state with a reason, if no reply in x days, auto suspend ;)

Complete process can be automated, like a user does not fly minimum amount per month, crashes too often etc. etc.

WARN them, display a message at dashboard with remaining days. Until suspension of clearance of warning.

@fequesada
Copy link
Author

A suggestion, I'm not sure if that's what Fatih meant. We have the Management Notes field: Perhaps if every time we added something there, the pilot would be notified via email, in that case, we wouldn't need to make this whole change.

@fequesada
Copy link
Author

Another option, add a new state WARNING ... Put pilots to that state with a reason, if no reply in x days, auto suspend ;)

Complete process can be automated, like a user does not fly minimum amount per month, crashes too often etc. etc.

WARN them, display a message at dashboard with remaining days. Until suspension of clearance of warning.

A great idea as well!

@FatihKoz
Copy link
Contributor

A suggestion, I'm not sure if that's what Fatih meant. We have the Management Notes field: Perhaps if every time we added something there, the pilot would be notified via email, in that case, we wouldn't need to make this whole change.

This would be too tricky, checking updates, sending mails on each update is not logical :(

@arthurpar06
Copy link
Contributor

Another option, add a new state WARNING ... Put pilots to that state with a reason, if no reply in x days, auto suspend ;)

Complete process can be automated, like a user does not fly minimum amount per month, crashes too often etc. etc.

WARN them, display a message at dashboard with remaining days. Until suspension of clearance of warning.

Hmm, it requires thinking about conditions to warn someone, a warning time that may depend on the condition that triggered the warning, conditions that automatically remove the warning, etc... It's a bit more complex I think, but it could be a nice idea

@FatihKoz
Copy link
Contributor

I can do it with a module :) like auto reject logic

@arthurpar06
Copy link
Contributor

If warning is a UserState and we want to display a mesasge on the dahsboard like for on leave it will also require changes in the core

@FatihKoz
Copy link
Contributor

Put the flash message and load dashboard, it will be visible... it is designed to show latest flash message, no need to send it from core.

A widget without visible items can do this easily, checks user warnings, push messages, keep track of them etc.

Anyway, it is another subject 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants