-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requires python2.7 breaks on python3 #1
Comments
To make it work with python3.7 modify this line.
Replace:
|
that's not enough to make pvshrink python compatible, there are other errors |
after some search i found a version which seems to correctly being ported to python3 and which apparently also still works with python2 : https://github.com/sensimple-contrib/pvshrink these are the 2 commits which make it python2 compatible: https://github.com/sensimple-contrib/pvshrink/commits?author=jsalatiel could you apply those to your version @pdw-mb ? what about submitting this upstream to the lvm2 project at http://sourceware.org/lvm2/ ? this is a very useful tool ! |
This deserves a PR! #3 |
On Ubuntu 18.04
#!/usr/bin/python2.7
sudo ./pvshrink /dev/sdf
Traceback (most recent call last):
File "./pvshrink", line 55, in
for seg in pvs.split("\n"):
TypeError: a bytes-like object is required, not 'str'
The text was updated successfully, but these errors were encountered: