-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{with}}
deprecation from ember-basic-dropdown v3
#272
Comments
I looked into this update this weekend and discovered a bunch of other updates that seemed to be required to ensure compatibility with newer versions of Ember. With that caveat, I got most things working, except for the Embroider runs of ember-try, which gave me a lot of errors along the lines of If anyone's curious, this is my working branch: https://github.com/gorner/ember-date-components/tree/update-ember-basic-dropdown-v6 For now, for the app I'm working on, I've realized it'll probably be sufficient to just specify ember-basic-dropdown v6 in npm overrides (or equivalently yarn resolutions). Edit: I've tried a couple of other things since then (including moving Moment to dependencies) to no avail. But on review, it looks like the current release may not work with Embroider either? Perhaps I will just go ahead and create the PR. |
Just a heads-up for anyone else using this workaround, it also worked with EBD v7 but does not work with EBD v8+ due to its conversion to the v2 addon format:
|
@mydea The app I'm working on is currently blocked on some updates, including the aforementioned ember-basic-dropdown v8, due to the issues mentioned previously. Do you have any near-term plans to bring this addon up to date (or accept PRs to do so)? If not, I'm considering publishing a fork with the necessary updates (possibly slimmed down to just the time-picker as we use ember-power-calendar for dates). |
I've gone ahead and published a fork, If the original repo is brought up-to-date I would be happy to deprecate the fork and point back to the original. |
This add-on currently depends on ember-basic-dropdown (EBD) v3, which uses the
{{with}}
helper which is deprecated (and raises a build-time warning) in Ember v3.26+ and removed in Ember v4.0.Currently working in an app (which we are slowly working towards upgrading to Ember v4) that directly depends on EBD v6 for other reasons and this package doesn't seem to conflict with it (apart from still raising the warning). Would be willing to submit a PR to update to ember-basic-dropdown v6 (which supports Ember v3.28+), or alternatively allow this package to accept a range of acceptable versions of EBD.
The text was updated successfully, but these errors were encountered: