Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpspec/prophecy is now explicitely needed for tests #177

Open
DavidPrevot opened this issue Aug 28, 2022 · 1 comment
Open

phpspec/prophecy is now explicitely needed for tests #177

DavidPrevot opened this issue Aug 28, 2022 · 1 comment

Comments

@DavidPrevot
Copy link

Hi,

Since PHPUnit dropped phpspec/prophecy from its dependencies (sebastianbergmann/phpunit#5033), the following error is triggered when running the testsuite with latest PHPUnit.

There was 1 error:

1) DeepCopyTest\TypeFilter\Spl\ArrayObjectFilterTest::test_it_deep_copies_an_array_object
PHPUnit\Framework\Exception: This test uses TestCase::prophesize(), but phpspec/prophecy is not installed. Please run "composer require --dev phpspec/prophecy".

Regards

David
@mnapoli
Copy link
Member

mnapoli commented Aug 29, 2022

Thanks, a pull request is most welcome if anyone wants to contribute that!

athos-ribeiro added a commit to athos-ribeiro/DeepCopy that referenced this issue Sep 5, 2022
@athos-ribeiro
Migrate to phpspec/prophecy-phpunit
e03ad06 
sebastianbergmann/phpunit#5033 changed phpunit
to no longer depend on phpspec/prophecy. This results in the need to add
a development dependency for phpspec/prophecy. Doing so results in a
warning, since PHPUnit\Framework\TestCase::prophesize() is deprecated
and will be removed in PHPUnit 10. Let's use the trait provided by
phpspec/prophecy-phpunit instead.

* Fixes myclabs#177
@athos-ribeiro athos-ribeiro mentioned this issue Sep 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to phpspec/prophecy-phpunit athos-ribeiro/DeepCopy
2 participants
@mnapoli @DavidPrevot