Artifact when changing content on second screen

[kaioberst]

Hi,

we are having artifacts on the second screen when changing the content of the second screen. First we display some text and further change to a webrtc view which covers the whole stream. I debugged a bit the code and found out, that some (not all) text views of the formerly added screen where still into the render tree.
I tried to remove them in RNExternalDisplayView.removeViewAt, but failed with IndexOutOfBounds.
Help would be appreciated!

Thanks in advance!

Kai

[femmon]

I have created a PR to address this problem #762

You can try it out by applying this patch:

diff --git a/node_modules/react-native-external-display/android/src/main/java/com/externaldisplay/RNExternalDisplayView.java b/node_modules/react-native-external-display/android/src/main/java/com/externaldisplay/RNExternalDisplayView.java
index 68bab8b..20c9702 100644
--- a/node_modules/react-native-external-display/android/src/main/java/com/externaldisplay/RNExternalDisplayView.java
+++ b/node_modules/react-native-external-display/android/src/main/java/com/externaldisplay/RNExternalDisplayView.java
@@ -59,13 +59,14 @@ public class RNExternalDisplayView extends ReactRootView implements LifecycleEve
 
   @Override
   public void removeViewAt(int index) {
-    if (index > 0) return;
     View child = getChildAt(index);
     super.removeView(child);
     subviews.remove(index);
     if (wrap != null && wrap.getChildCount() > 0) {
       for (int i = 0; i < wrap.getChildCount(); i++) {
-        wrap.removeViewAt(i);
+        if (i == index) {
+          wrap.removeViewAt(i);
+        }
       }
     }
   }