Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] GMW share/open and XOR/AND bit operations #200

Closed
wants to merge 88 commits into from
Closed

Conversation

p-flock
Copy link
Member

@p-flock p-flock commented Jun 9, 2020

just opening up a PR so it's easier to comment and leave feedback

@p-flock
Copy link
Member Author

p-flock commented Jun 9, 2020

This looks really good so far. The next steps will be to write tests in demos/BMW_demo/test.js to reflect the functionality of the demo as it exists now (the tests will change when we implement AND/XOR).

Something I did not mention before is that you can run npm run-script lint to run the linter on all the code and point out syntax that doesn't conform to the style we use throughout the library. We can also set up your development environment to do this automatically. (My commit was just linting a couple of the files, I did not touch BMW_OT.js yet.

This note has nothing to do with the functionality of the code, but we should make sure we standardize the naming of functions to be "GMW" instead of "BMW" to be consistent with the name of the authors of the paper we're basing this code on.

Copy link
Member Author

@p-flock p-flock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! We won't merge to the base branch yet, we will keep that until we integrate the functionality into the library.

demos/BMW_demo/bmw_open.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_open.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_open.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_open.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_open.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_share.js Outdated Show resolved Hide resolved
demos/BMW_demo/bmw_share.js Outdated Show resolved Hide resolved
demos/BMW_demo/mpc.js Outdated Show resolved Hide resolved
demos/BMW_demo/mpc.js Outdated Show resolved Hide resolved
demos/BMW_demo/server.js Outdated Show resolved Hide resolved
@p-flock p-flock linked an issue Aug 11, 2020 that may be closed by this pull request
@wyatt-howe
Copy link
Member

Here's some GMW changes I made in the summer. There was a race condition in the composition operation which I did not get around to debugging until today. I added a demo to show how it it possible to do multiple arithmetic operations using GWM and convert back to Shamir sharing without any explicit opens. I guess this means JIFF can officially be considered a hybrid secret sharing library!

@p-flock
Copy link
Member Author

p-flock commented Aug 3, 2021

closing but keeping the branch around, since this is not in active dev

@p-flock p-flock closed this Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GMW Sharing/Reconstruction
3 participants