Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up decoder code #491

Merged
merged 1 commit into from
Oct 9, 2024
Merged

chore: clean up decoder code #491

merged 1 commit into from
Oct 9, 2024

Conversation

muktihari
Copy link
Owner

  • reset d.fileId to nil on releaseTemporaryObjects()
  • fix typo profilType -> profileType
  • remove (*Decoder) log as it simply a fmt.Fprintf.
  • check d.option.logWriter == nil before try printing the log to avoid unnecessary allocation when d.option.logWriter is nil.
  • simplify other codes.

@muktihari muktihari added the chore update not related to the functionality of the sdk, e.g. update workflow label Oct 9, 2024
@muktihari muktihari added this to the Unreleased milestone Oct 9, 2024
@muktihari muktihari self-assigned this Oct 9, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6bf188f) to head (c9d3845).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #491   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3859      3860    +1     
=========================================
+ Hits          3859      3860    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit f20393c into master Oct 9, 2024
5 checks passed
@muktihari muktihari deleted the chore/clean-up-decoder branch October 9, 2024 12:26
@muktihari muktihari added this to the v0.24.4 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore update not related to the functionality of the sdk, e.g. update workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants