Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify decoder's bits #488

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

muktihari
Copy link
Owner

  • Now we only check whether bits' store has reach zero. The bits validity checking is removed since we already check the value validity in decoder and The bitsize checking is also removed since it's not FIT files related but it's an implementation detail of Profile.xlsx.
  • The zero size of bits is now reserved as global variable, this makes comparing bits to its zero value a bit faster.

@muktihari muktihari added the chore update not related to the functionality of the sdk, e.g. update workflow label Oct 7, 2024
@muktihari muktihari added this to the Unreleased milestone Oct 7, 2024
@muktihari muktihari self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fa631b9) to head (68bab50).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #488   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3853      3855    +2     
=========================================
+ Hits          3853      3855    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit acfe24c into master Oct 7, 2024
3 checks passed
@muktihari muktihari deleted the chore/simplify-decoder-bits branch October 7, 2024 12:46
@muktihari muktihari added this to the v0.24.4 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore update not related to the functionality of the sdk, e.g. update workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants