Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expanding field that has only one component #483

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented Oct 5, 2024

If a field has only one component and its value is not an invalid value, expand it even if its value is zero e.g. speed (0) -> enhanced_speed (0).

@muktihari muktihari added the bug Something isn't working label Oct 5, 2024
@muktihari muktihari added this to the v0.24.3 milestone Oct 5, 2024
@muktihari muktihari self-assigned this Oct 5, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4a908f) to head (37f730a).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3848      3848           
=========================================
  Hits          3848      3848           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 190e0e4 into master Oct 5, 2024
5 checks passed
@muktihari muktihari deleted the fix/decoder-should-expand-if-one-component branch October 5, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants