Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fitgen's factory and mesgdef on evaluating scale offset #481

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

muktihari
Copy link
Owner

Scale and offset do not apply for field that has more than one components, set it to default scale 1 and offset 0.

@muktihari muktihari added the bug Something isn't working label Oct 5, 2024
@muktihari muktihari added this to the v0.24.3 milestone Oct 5, 2024
@muktihari muktihari self-assigned this Oct 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (405d6b0) to head (df2f151).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #481   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3810      3810           
=========================================
  Hits          3810      3810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 21f4b2d into master Oct 5, 2024
5 checks passed
@muktihari muktihari deleted the fix/fitgen-on-handling-scale-offset branch October 5, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants