Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify proto value #480

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

muktihari
Copy link
Owner

  • Since Go v1.21.0, the compiler is smart enough to do type inference for generic slices, we don't need to do []E(s) anymore.
  • For proto.SliceBool since we only accept []typedef.Bool, this function does not need to be generic.

@muktihari muktihari added the chore update not related to the functionality of the sdk, e.g. update workflow label Oct 4, 2024
@muktihari muktihari added this to the v0.24.2 milestone Oct 4, 2024
@muktihari muktihari self-assigned this Oct 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (405d6b0) to head (6a0de9e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #480   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3810      3810           
=========================================
  Hits          3810      3810           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 9dc160f into master Oct 4, 2024
5 checks passed
@muktihari muktihari deleted the chore/simplify-proto-value branch October 4, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore update not related to the functionality of the sdk, e.g. update workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants