Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filedef activity file add sports and update its sorting #464

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

muktihari
Copy link
Owner

  • Add sports messages in Activity File. FIT files produced by Garmin devices typically has this message, and it can be multiple sports messages such as when doing a Triathlon.
  • Manually put messages that, we know upfront, have no timestamp at the beginning of the resulting messages, we don't need to include it to be sorted. This will save a bit of resource and time.

@muktihari muktihari added the enhancement New feature or request label Sep 22, 2024
@muktihari muktihari added this to the Unplanned milestone Sep 22, 2024
@muktihari muktihari self-assigned this Sep 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (b8c1b00) to head (af2ec71).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #464   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          42       42           
  Lines        3697     3710   +13     
=======================================
+ Hits         3695     3708   +13     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 1cdf215 into master Sep 22, 2024
5 checks passed
@muktihari muktihari deleted the feat/filedef-activity-add-sports branch September 22, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants