refactor!: change decoder's listener behavior #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: #182
BREAKING CHANGES:
OnMesg
method returns so any listener that process the message concurrently should copy the mesg before return. For legacy behavior (<= v0.14.0), usedecoder.WithBroadcastMesgCopy()
What's Changed:
filedef's Listener
now copy the mesg before processing it concurrently to accommodate the behavior change. It copies the mesg using pool of reusable messages to reduce alloc.Benchmark:
close #182