Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf!: reduce crc16 pointer dereference #184

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

muktihari
Copy link
Owner

BREAKING CHANGES:

  • MakeFitTable renamed to MakeFITTable

Benchmark:

goos: darwin
goarch: amd64
pkg: github.com/muktihari/fit/kit/hash/crc16
cpu: Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
           old.txt                  new.txt               
           sec/op       sec/op     vs base                
Write-4   27.82µ ± 0%   21.55µ ± 0%  -22.53% (p=0.000 n=10)

          old.txt               new.txt             
            B/op        B/op     vs base            
Write-4   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

          old.txt               new.txt             
         allocs/op   allocs/op   vs base            
Write-4   0.000 ± 0%   0.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

close #180

@muktihari muktihari added the performance Changes related to performance improvement label Apr 15, 2024
@muktihari muktihari self-assigned this Apr 15, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 99.91%. Comparing base (4066db4) to head (c32f2fd).

Files Patch % Lines
kit/hash/crc16/crc16.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master     #184      +/-   ##
===========================================
- Coverage   100.00%   99.91%   -0.09%     
===========================================
  Files           42       42              
  Lines         3494     3500       +6     
===========================================
+ Hits          3494     3497       +3     
- Misses           0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit ca78c95 into master Apr 15, 2024
4 checks passed
@muktihari muktihari deleted the issue-180/reduce-crc16-pointer-deref branch April 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Changes related to performance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hash/crc16: reduce pointer value dereference on Write method
2 participants