Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please offer better color contrast on the pie charts showing Bike Share Toronto bike availability #12

Open
unforgettableid opened this issue Aug 10, 2022 · 4 comments
Assignees

Comments

@unforgettableid
Copy link

Hi Mathieu!

The problem

I have installed MonTransit and the "Bike Share Toronto" agency. The pie charts in the "Nearby Stations" list show how full each station is. Unfortunately, the contrast between the dark green and light green colors on each pie chart is not huge. This makes the pie charts more difficult to read at a glance — especially, perhaps, in bright sunlight. (If you wish, you may check the contrast between two colors using the WebAIM contrast checker or by searching for other contrast checkers.)

My suggestion

I would suggest that you instead use the exact same colors as the official PBSC app. This is because Bike Share Toronto users are already familiar with these colors and their meaning. So, something like #0BA546 for regular bikes, #000000 for e-bikes, and #FFFFFF for empty docks.

Conclusion

I would be curious to hear your thoughts.

Thank you for writing and maintaining MonTransit; and thank you for reading this!

I am using an LG G5 running Android 8.0.0 "Oreo".

@mmathieum
Copy link
Member

Hi, thanks for the request.

The colors are set up in this file:

https://github.com/mtransitapps/ca-toronto-share-bike-android/blob/master/src/main/res/values/bike_station_values.xml

I will try the suggested colors and publish an app update when I found the time.

@unforgettableid
Copy link
Author

I appreciate your reply!

It looks like MonTransit also draws a very thin outline around the edges of the pie chart. In the current version of MonTransit, this outline is white. I think #0BA546 would be a better color for the outline. Again, this helps to match what the official PBSC app does.

@mmathieum mmathieum self-assigned this Aug 11, 2022
mmathieum added a commit to mtransitapps/ca-toronto-share-bike-android that referenced this issue Aug 11, 2022
mmathieum added a commit to mtransitapps/ca-toronto-share-bike-gradle that referenced this issue Aug 11, 2022
@mmathieum
Copy link
Member

Hi @unforgettableid , I have published an update with new colors.

Please, try it and confirm it's better for you.
https://play.google.com/store/apps/details?id=org.mtransit.android.ca_toronto_share_bike
(I haven't updated the app screen shot yet)

@unforgettableid
Copy link
Author

Dear Mathieu: I tried the new version, and the new colors are better -- I appreciate your efforts!

Is it possible you might be able to please use black for e-bikes, instead of dark green? The extra contrast might let users find nearby e-bikes more quickly and easily. Black next to green gives you a superb contrast ratio of ~7.8:1. (Source.)

If you don't want to use black, an alternative might be #54145C -- dark magenta. This would provide a good contrast ratio of ~4.8:1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants