Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve custom path specification for toolkits (MKL) #289

Open
gdevenyi opened this issue Jun 23, 2022 · 1 comment
Open

Improve custom path specification for toolkits (MKL) #289

gdevenyi opened this issue Jun 23, 2022 · 1 comment

Comments

@gdevenyi
Copy link

intel-mkl is now available on Ubuntu 22.04, however its installation doesn't conform to the assumptions in the Makefile.

MKL_BASE is expanded to $MKL_BASE/include, however the includes are at /usr/include/mkl

Similarly, the libs are just at /usr/lib.

MKL_INCLUDE and MKL_LIBS might be a better way.

Ideally of course an autoconf ./configure or a cmake file would remove the need to hard-code paths in a hand written Makefile.

@jtamir
Copy link
Member

jtamir commented Jun 23, 2022

Hi, by any chance could you make a pull request with your proposed changes? You could follow the approach we took for specifying the CUDA include/lib paths while maintaining backward compatibility, as NVIDIA also changed the paths after a certain CUDA version. See https://github.com/mrirecon/bart/blob/master/Makefile#L166

Note that, though we don't have configure or cmake (any more), the intended use is to not modify the Makefile and instead define a Makefile.local that has the specific build variables defined. For example:

~/bart $ cat Makefile.local

PARALLEL=1

# cuda
CUDA=1
CUDA_BASE=/usr/local/cuda
CUDA_LIB=lib64

# Intel
MKL=1
MKL_BASE=/opt/intel/compilers_and_libraries/linux/mkl
LINKER=icc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants