Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Calculators functions #1

Open
mreed72 opened this issue Nov 29, 2018 · 1 comment
Open

Testing Calculators functions #1

mreed72 opened this issue Nov 29, 2018 · 1 comment
Labels
help wanted Extra attention is needed

Comments

@mreed72
Copy link
Owner

mreed72 commented Nov 29, 2018

Need some testing of the calculators to make sure that every possible calculation can be done using the code as written. I have found in the past that some fuel models and loads would give incorrect figures in certain scenarios (I believe I have fixed the code to account for the ones I'm aware of).

Would like to test every fuel model and load condition (xfuels.classFuels.GetAvFuels)
Would like to test every smpCalc condition as well to make sure there are no errors.

@mreed72 mreed72 added the help wanted Extra attention is needed label Nov 29, 2018
@mreed72
Copy link
Owner Author

mreed72 commented Apr 4, 2019

In the xFuels.ClassFuels.smpCalc section, each conditional has an "Else", I believe this is causing an issue when trying to calculate several numbers. for instance, I attempted to calculate a large fire using exactly 20 miles as the distance, and I get a return of zero which then exceeds the guidelines when it shouldn't.

I'm thinking about removing the else from each statement, but that could create new issues. Any thoughts on a resolution would be greatly appreciated.

@mreed72 mreed72 pinned this issue Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant