-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget doesn't return results for DOIs with extra stashes. #135
Comments
You need to encode the 2nd half of the doi |
Hum...I would expect the javascript widget to do if we are trying to make the widget as easy as possible to use. Also the DIO is a value. Not encoding one half of a value and encoding the other half doesn't make a whole lot of sense. |
+1 good points |
@rcpeters, @acabunoc -- Quite frankly the widget treats the doi as a string, you could put any number of slashes in it and it will still create an endpoint string. It also does this with the updated code, yet to be committed. Have you tried: https://badges.mozillascience.org/papers/10.1093/nar/gkt1063/badges This yields: "Page not found" Does this article have any badges? |
@Alicole - I think we can handle this on the app side for usability :) |
@acabunoc -- Thanks for that -- yes when you use the url encoding character for / %2F it works. Agreed -- for usability it'll probably be better if you can find a way to make this work at your end. |
New widget with different display options (see docs/widger.js) and demos (in public/widgets/demos). Also provides solutions for mozillascience#142 (loading spinner) and mozillascience#135 (DOIs with extra slashes)
While this is address in |
@acabunoc -- in terms of the url with %2F -- is this something that you've look at? Or is it still outstanding? Do you know if this has posed any issues with the wider community? |
Hey @Alicole! i haven't had a chance to look at it -- still outstanding! It's pretty rare, but does affect the wider community. I'm still at #mozsprint, this might be a good task for today! |
@acabunoc -- Thanks it would be great if this was closed soon, as it would help prevent any issues with url path inconsistencies. |
@Alicole I'll make this a priority! |
on review #212 |
The widget returns badges for doi
10.1186/2047-217X-3-13
https://badges.mozillascience.org/papers/10.1186/2047-217X-3-13/badges
However the widget doesn't return badges for
10.1093/nar/gkt1063
https://badges.mozillascience.org/papers/10.1093/nar/gkt1063/badges I'm guess this has to do with the second slash of the doi.
The text was updated successfully, but these errors were encountered: