Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

janus_rtp_header_update should be called before forwarding #51

Open
gfodor opened this issue Apr 4, 2020 · 1 comment
Open

janus_rtp_header_update should be called before forwarding #51

gfodor opened this issue Apr 4, 2020 · 1 comment

Comments

@gfodor
Copy link
Contributor

gfodor commented Apr 4, 2020

The janus_rtp_header_update function (https://github.com/meetecho/janus-gateway/blob/master/plugins/janus_videoroom.c#L6589) is used to adjust the RTP sequence number, among other things, in scenarios where either the SSRC changes or if a stream is paused/resumed. All existing Janus plugins call this (eg https://github.com/meetecho/janus-gateway/blob/master/plugins/janus_videoroom.c#L7176) we should in the SFU as well.

@vincentfretin
Copy link
Contributor

Indeed, in the videoroom plugin I see this is called when using simulcast when the video quality change, or after using a switch request (from the doc: switch request can be used to change the source of the media flowing over a specific PeerConnection (e.g., I was watching Alice, I want to watch Bob now) without having to create a new handle for that).
The janus-plugin-sfu plugin doesn't currently implement those features.
I see that https://github.com/netology-group/janus-conference Rust plugin implements janus_rtp_header_update, see https://github.com/netology-group/janus-conference/blob/4b1eb19a7079c942f925a0fe0d337ec9a7010624/src/janus_rtp.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants