-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements for moments pages #15404
Comments
Hi @slightlyoffbeat , I’d love to work on this good first bug. Could you please assign it to me? Also the Figma File is unavailable at the moment, can you please look into that too. |
@ITSMEPRIYANSHUUCHAT I assigned it to you and updated the Figma file so that you can view it. Thank you for volunteering! |
Just another question, to make sure we are on the same page, the modifications are required for page 20,21,22,23 and 24. Am i right? As all of them are having similar issue. |
Some more things that I stumbled upon: --title-md-size: 2.5rem; (The current Font-size) I would suggest that we rather use inline styling( if some custom size is required) or use {--title-2xs-size} instead. Personally, I would go for 1.75rem, as it is the middle ground between too small to too big, please give your inputs for next steps. |
@ITSMEPRIYANSHUUCHAT that is correct. It is for page 20, 21, 22, 23, and 24. For your second question, i'm going to tag some Mozilla websites team members to see if they can advise @craigcook @alexgibson @stephaniehobson |
@ITSMEPRIYANSHUUCHAT if we can try and stick to one of our standard heading sizes as defined in our design system, that would be preferable thanks. |
Description
A UX designer has requested some minor improvements to the moments pages that recently went live.
The first moments page will have traffic on Dec 10, so we have some time.
This is a lower priority, but would be nice to have.
Requested Changes
highest priority is:
title-md-size
More subtle suggestions:
Figma File
The text was updated successfully, but these errors were encountered: