Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entitylist] Ensure that we don't generate entries for a domain with itself #49

Open
fmarier opened this issue Oct 3, 2017 · 2 comments

Comments

@fmarier
Copy link

fmarier commented Oct 3, 2017

An entity list entry like this:

"properties": [
    "example.com"
],
"resources": [
    "example.com",
    "example.net"

]

Should lead to only one entry on the resulting pairwise allow list: example.com/?resource=example.net

It should not include example.com/?resource=example.com

@groovecoder
Copy link
Contributor

It looks like this is already the case. E.g., there are no entitylist entries logged for consiliummedia.com which is defined:

    "Consilium Media": {
        "properties": [
            "consiliummedia.com"
        ],
        "resources": [
            "consiliummedia.com"
        ]
    },

And, we don't create a property-resource allowance entry for the same domain. E.g., there's no complex.com/?resource=complex.com entry even though Complex Media is defined with complex.com in both the properties and resources:

    "Complex Media": {
        "properties": [
            "complexmedianetwork.com",
            "complex.com",
            "collider.com",
            "solecollector.com",
            "pigeonsandplanes.com",
            "theridechannel.com",
            "firstwefeast.com"
        ],
        "resources": [
            "complexmedianetwork.com",
            "complex.com"
        ]
    },

@groovecoder
Copy link
Contributor

I'm leaving this open and adding a Continuous Integration label to it and 2 other "ensure" issues we have. We can roll those into a meta-issue to add all 3 checks to a single CI script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants