-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw an error when the size of a generated digest256 list exceeds Firefox's maximum chunk size #104
Comments
As a fix to #104 gracefully exit if the file is bigger than the max size
This can be marked as fixed now? |
Not yet, I need to refactor the code so that it exits before publishing at all. I conveyed that with @englehardt and will remove this as a blocker for #109 |
Hi @skim1102 Can I work on this? |
Hey @shreyagupta30! Just checking on the status of this issue. Do you need anything clarified or have questions on the implementation for fixing this issue? |
Yes @skim1102, I am still not able to figure out how to get started here. :( |
As discussed on this comment the assertion for the max size should differ based on what version the branch is using.
|
Looking into it. |
See mozilla-services/shavar-prod-lists#79 (comment) for the problems that can result from not doing this. This max chunk size is given here, and enforced here.
The text was updated successfully, but these errors were encountered: