Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error when the size of a generated digest256 list exceeds Firefox's maximum chunk size #104

Open
englehardt opened this issue Oct 28, 2019 · 7 comments
Assignees
Labels

Comments

@englehardt
Copy link
Contributor

See mozilla-services/shavar-prod-lists#79 (comment) for the problems that can result from not doing this. This max chunk size is given here, and enforced here.

@englehardt englehardt changed the title Throw an error when the size of a generated digest256 list does not exceeds Firefox's maximum chunk size Throw an error when the size of a generated digest256 list exceeds Firefox's maximum chunk size Oct 28, 2019
say-yawn added a commit that referenced this issue Nov 11, 2019
As a fix to #104 gracefully exit if the file is bigger than the max size
@groovecoder
Copy link
Contributor

This can be marked as fixed now?

@say-yawn
Copy link
Contributor

Not yet, I need to refactor the code so that it exits before publishing at all. I conveyed that with @englehardt and will remove this as a blocker for #109

@shreyagupta30
Copy link

Hi @skim1102 Can I work on this?

@say-yawn
Copy link
Contributor

Hey @shreyagupta30! Just checking on the status of this issue. Do you need anything clarified or have questions on the implementation for fixing this issue?

@shreyagupta30
Copy link

shreyagupta30 commented Mar 20, 2020

Yes @skim1102, I am still not able to figure out how to get started here. :(

@say-yawn
Copy link
Contributor

say-yawn commented Apr 2, 2020

As discussed on this comment the assertion for the max size should differ based on what version the branch is using.

  • for versions equal to or higher than 73 the max size is 4 mebibytes as mentioned in bug 1594497
  • for versions equal to or lower than 72 the max size is 1 mebibytes

@shreyagupta30
Copy link

As discussed on this comment the assertion for the max size should differ based on what version the branch is using.

* for versions equal to or higher than 73 the max size is 4 mebibytes as mentioned in [bug 1594497](https://bugzilla.mozilla.org/show_bug.cgi?id=1594497)

* for versions equal to or lower than 72 the max size is 1 mebibytes

Looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants