-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
figure out what to do with logins #10
Comments
I was talking to @rail about this and he pointed out that none of the UI interactions use backend endpoints that require auth. So we can just rip out the frontend login stuff instead of trying to fix it. I'm guessing it only exists because this used to be integrated with the common |
I was poking at unrelated things today and realized that downloads of internal artifacts from the UI don't work if you're not logged in. I can't confirm that they do work if you are logged in, but presumably a session cookie would be set in that case, and they would. So, now I'm not sure whether or not we can rip out logins. |
I ended up making logins work, but internal artifact downloads still do not. This is because the links to them are simple tags, which can't include an Authorization header. I think it's possible to change the frontend to download with an XHR request after a bit of research, but I don't know if it's worthwhile. |
Even after #9 is fixed, login will be broken because the
/auth0
endpoints don't exist. We probably need to change auth to talk directly to Taskcluster, although this needs a bit more investigation first.The text was updated successfully, but these errors were encountered: