Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There are no rc for 67 #544

Open
calixteman opened this issue May 21, 2019 · 8 comments
Open

There are no rc for 67 #544

calixteman opened this issue May 21, 2019 · 8 comments

Comments

@calixteman
Copy link

For firefox there are (from 63 to 65).0rc(1 or 2) versions but nothing for 66 nor 67.
Rc versions are available in crash-stats:
https://crash-stats.mozilla.org/search/?signature=%3DOOM%20%7C%20small&product=Firefox&version=67.0rc1&date=%3E%3D2019-05-20T09%3A06%3A00.000Z&date=%3C2019-05-21T09%3A06%3A00.000Z&_facets=signature&_sort=-date&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform#facet-signature
I'm moving crash-stop to use buildhub2 but I really need to know what are the rc versions.

@willkg
Copy link
Contributor

willkg commented May 21, 2019

Socorro has a completely different scraping system than Buildhub2 does, so I'm not sure I'd compare the two.

I'll look for an example buildinfo file and then try to figure out what happened.

@calixteman
Copy link
Author

We've these information in buildhub1 (I know the diffs between 1 & 2) so it'd be nice to have them too in buildhub2 (I don't want to write my own scraper).
I need to know when a build (release) is a rc one to be able to set release channel to beta to get data from socorro for Firefox.

@willkg
Copy link
Contributor

willkg commented May 21, 2019

@peterbe and I looked into this. I'm still getting my feet wet with buildhub and buildhub2 so I don't really know what I'm doing, yet.

Let's use 67.0rc1 as an example. The build id is 20190513195729. That shows up in Buildhub2 as 67.0:

https://buildhub.moz.tools/?versions[0]=67.0&products[0]=firefox

Here's the archive.mozilla.org buildhub.json record:

https://archive.mozilla.org/pub/firefox/candidates/67.0-candidates/build1/linux-i686/en-US/buildhub.json

The version in the record is "67.0".

Thus archive.mozilla.org has the wrong version number for this build and Buildhub2 just reports what it got.

For version 65, that data was migrated into Buildhub2 from Buildhub, so it was built with whatever figuring Buildhub did.

We need to fix this in whatever it is that generates the buildhub.json files in archive.mozilla.org. We should probably fix all the existing buildhub.json files as well. Then I think I can re-ingest those files and we'll be good.

@calixteman Do you know where we can write up a bug for fixing the thing that generates buildhub.json files in archive.mozilla.org?

@calixteman
Copy link
Author

@JohanLorenzo ^^

@MihaiTabara
Copy link

This file is inherited from build generation time and then beetmover amends some of the fields like size, date and url. So if the version is wrong, I assume that comes from the build-generation time. I'll double-check now.

@MihaiTabara
Copy link

Spoke with @willkg privately. We need a build peer first to get this fixed at build generation time. We'll follow-up in a bug with the conversation.

@willkg
Copy link
Contributor

willkg commented May 21, 2019

I wrote up this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1553179

I'll help work through that bug and then figure out what we need to do in Buildhub2.

@bhearsum
Copy link
Contributor

When #610 is in production we'll have beta channel entries in Buildhub for all release channel builds. If I understand the original issue correctly, this should mean that Socorro will be able to find them (and it won't have to do any data munging to do so). @calixteman, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants