Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ratcheting search : Does it return 0 or 1 result on a user's first login? #214

Open
gene1wood opened this issue Aug 7, 2018 · 0 comments

Comments

@gene1wood
Copy link
Contributor

gene1wood commented Aug 7, 2018

When a user logs in for the first time with any IdP and Auth0 runs the force-users-login-most-secure-method.js rules, does this piece of code execute because the search for auth0 profiles with the same email address comes back empty? Or does that search always produce at least one result, which is the profile of the user that is in the login process right now?

If it's the latter does that mean that this piece of code never actually executes because at least one search result is always returned?

If so, what do you think about changing this piece of code to deny the user access instead of permitting them. The rationale would be that this is a code path we never expect to execute and so if it does something unexpected is happening and we should probably deny access just to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant