Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployed infosec-dev CodeBuild project has branch filter of master which isn't captured in code #253

Open
gene1wood opened this issue Nov 7, 2018 · 2 comments

Comments

@gene1wood
Copy link
Contributor

gene1wood commented Nov 7, 2018

How is the branch filter of master set on the AWS CodeBuild project? It looks like it's not set in the CloudFormation template and isn't even supported in CloudFormation.

If this is done manually, can we document this or create a Lambda function to provision it, or switch from CloudFormation to terraform or bash?

@gene1wood
Copy link
Contributor Author

Andrew confirms that the branch filter was setup manually

@gene1wood
Copy link
Contributor Author

Also, this part of the CloudFormation template will overrite the manual branch filter settings and the github webhook (which is changed to just push) if applied/updated.

Maybe we take this binding out entirely to avoid this and do the whole thing manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant