Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display login errors on NLX #234

Open
gdestuynder opened this issue Oct 10, 2018 · 2 comments
Open

Display login errors on NLX #234

gdestuynder opened this issue Oct 10, 2018 · 2 comments

Comments

@gdestuynder
Copy link
Contributor

gdestuynder commented Oct 10, 2018

Currently login errors are sent to the SSO dashboard in the GET parameter, using a JWT.

We would like to send the errors to NLX using a GET parameter, with state verification instead, because this allows for a better UX in NLX.

Not only is this faster and more consistent, but it also allows NLX to act on the error message in different ways.

Since NLX is currently hosted by auth0, the state verification works out of the box. What's needed is the ability to ingest and display messages.

Proposal:

/login?nlx_error=base64encodedmsg&state=encodedString

where NLX would display the message.

The current list of messages are: https://github.com/mozilla-iam/sso-dashboard/blob/master/dashboard/auth.py#L129-L165

This work is part of the LoginV2 efforts.

cc @mbransn @hidde @gene1wood

@gene1wood
Copy link
Contributor

Would the GET parameters also include state? Such that it would look like

/login?nlx_error=base64encodedmsg&state=encodedString

@gdestuynder
Copy link
Contributor Author

yes, it has to

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants