Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply button disabled #20

Closed
clauslack opened this issue May 23, 2014 · 3 comments
Closed

Apply button disabled #20

clauslack opened this issue May 23, 2014 · 3 comments
Assignees
@reiniero

Comments

@clauslack
Copy link
Contributor

When edit an select query, the apply button is not enabled. The procedure
EnableApplyButton returns High(FResultControls)=-1. (querywindow.pas)
I test under Windows XP lazarus 1.2.2 fpc 2.6.4 with source motaz-turbobird-4e492e0.zip (22/05/2014)
With TurboBird 1.0.2 the button Apply is enabled.

Regards
@reiniero
Copy link
Collaborator

Thanks for reporting. The cause is the removal of the AddResultControls function in commit 46bb5e0. I'll look into it.

@reiniero reiniero self-assigned this May 24, 2014
reiniero added a commit that referenced this issue May 24, 2014
@reiniero
Enable apply button if records changed in select query. Should fix is…
049fba5 
…sue #20. Note that other code still needs to be fixed (commit button etc); also needs performance test
reiniero added a commit that referenced this issue May 25, 2014
@reiniero
Further work on issue #20 and related issues. Not finished.
626a9ec
@reiniero
Copy link
Collaborator

The latest commit should have fixed this issue. Could you please test and verify it works for you?
Thanks

Note issue #21 for inserts though...

reiniero added a commit that referenced this issue May 25, 2014
@reiniero
Additional fixes for Apply, Commit button. Issue #20 should be fixed now
0dad5bf
@clauslack
Copy link
Contributor Author

Now fixed.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reiniero reiniero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reiniero @clauslack