Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

convert_dataset_json.py does not respect parameter --split #497

Open
matthiasgeihs opened this issue Aug 1, 2023 · 1 comment
Open

convert_dataset_json.py does not respect parameter --split #497

matthiasgeihs opened this issue Aug 1, 2023 · 1 comment
Assignees
@tbarton16

Comments

@matthiasgeihs
Copy link

https://github.com/mosaicml/llm-foundry/blob/bd8127252c660e45ed01413645d29427f86c085a/scripts/data_prep/convert_dataset_json.py#L204C4-L204C4

out=os.path.join(args.out_root), should be out=os.path.join(args.out_root, folder_split), as in convert_dataset_hf.py.
@tbarton16 tbarton16 self-assigned this Aug 2, 2023
@tbarton16
Copy link
Contributor

I will work on fixing this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbarton16 tbarton16

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tbarton16 @matthiasgeihs