Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document.getElementById(...) is null #2

Open
mudrd8mz opened this issue Apr 15, 2024 · 6 comments
Open

document.getElementById(...) is null #2

mudrd8mz opened this issue Apr 15, 2024 · 6 comments

Comments

@mudrd8mz
Copy link

  1. I have a simple true / false question prepared in the course question bank.
  2. ID number defined for both the category and the question.
  3. New Page resource created in the course.
  4. Attempting to embed the question using the Insert > Embedded question menu.
  5. When I select the category and the question
  6. Nothing happens when I press the "Embed question" button
  7. Browser console reports error: Uncaught TypeError: document.getElementById(...) is null

with the line number indicating the line

const iframeDescription = document.getElementById('id_iframedescription').value;

@mudrd8mz
Copy link
Author

Using the browser console, I can confirm that when the dialogue window is opened, the id_questionidnumber dropdown menu is found, but id_iframedescription gives null.

@timhunt
Copy link
Member

timhunt commented Apr 16, 2024

Oh! drat!

This is beacuse I have not got aroudn to pushing the latest filter_embedquestoin code to github.

Sorry to waste your time. I will get that sorted then let you know.

@marycooch
Copy link

Great thanks Tim - we will be upgrading Academy on the 10th and we use this plugin heavily.

@TomoTsuyuki
Copy link

Hi @timhunt ,

Has the filter_embedquestoin plugin been updated?
Is this issue fixed?

@t-schroeder
Copy link

I can no longer reproduce this problem.

It occurred with:

  • tiny_embedquestion 1.0
  • filter_embedquestion 2.2
  • Moodle 4.3.4

It doesn't occur with:

  • tiny_embedquestion 1.0
  • filter_embedquestion 2.2
  • Moodle 4.3.8

@gemguardian
Copy link

@mudrd8mz it works when you use the latest version of FIlter Embed Question on Github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants