Deprecate 'native' in favor of montage/ui/base

[NV]

Refactor all components to use montage/ui/base where possible instead of montagejs/native. Digit uses montage/ui/base, make matte more consistent with digit.

• Button
  • enabled property in serialization doesn’t change anything
  • 'hold' event is missing

[NV]

Working on it. I would assign it to myself but I don’t have permissions.
Update: thanks, have permissions now.

[NV]

After NV/matte@38a1a39 few specs started to fail. One of them related to "hold" event. I looked at abstract-button.js and press-composer.js and couldn’t find anything about "hold" event. Was it replaced by something else?

[francoisfrisch]

I think we missed it when we refactored the code… Add it to the abstract class

On Aug 16, 2013, at 6:25 PM, Nikita Vasilyev [email protected] wrote:

After NV/matte@38a1a39 few specs started to fail. One of them related to "hold" event. I looked at abstract-button.js and press-composer.js and couldn’t find anything about "hold" event. Was it replaced by something else?

—
Reply to this email directly or view it on GitHub.

[NV]

When 'longAction' event suppose to fire for button? Should it fire on click and hold (for holdThreshold ms)? It currently doesn’t.

[aadsm]

It should be fired when the translate composer fires the longPress event

[NV]

You mean press composer? Abstract button doesn’t use translate composer.

I asked because 'longAction' doesn’t get triggered on mouse events and NV@6e17168 fails.

[francoisfrisch]

So we should have a longAction when the longPress is fired.

longAction should get triggered with mouse events if is doesn't it's a bug.

[aadsm]

Yes, sorry, I did mean press composer.