Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken pagination if .Site.Params.showAllPostsArchive not set #83

Open
jasonrogena opened this issue Jul 8, 2021 · 0 comments · May be fixed by #84
Open

Broken pagination if .Site.Params.showAllPostsArchive not set #83

jasonrogena opened this issue Jul 8, 2021 · 0 comments · May be fixed by #84

Comments

@jasonrogena
Copy link

jasonrogena commented Jul 8, 2021 •
edited
Loading

Seems this pull request introduced an issue where if the .Site.Params.showAllPostsArchive variable is not set, pagination breaks such that you only see the first page. The README suggests that the default value for .Site.Params.showAllPostsArchive is false. Temporary fix is to add the following in the site's config.toml:

[params]
  showAllPostsArchive = false
jasonrogena added a commit to jasonrogena/hugo-theme-cactus that referenced this issue Jul 8, 2021
@jasonrogena
Allow default .Site.Params.showAllPostsArchive
a832f69 
Allow, if .Site.Params.showAllPostsArchive is not set, the site to
function as if the variable has been set to false.

Fixes  monkeyWzr#83

Signed-off-by: Jason Rogena <[email protected]>
@jasonrogena jasonrogena linked a pull request Jul 8, 2021 that will close this issue
Open
jasonrogena added a commit to jasonrogena/jasonrogena.github.io that referenced this issue Jul 8, 2021
@jasonrogena
Fix pagination issue
45ff736 
Fix issue in pagination caused by
monkeyWzr/hugo-theme-cactus#83

Signed-off-by: Jason Rogena <[email protected]>
@RobbiNespu RobbiNespu mentioned this issue Nov 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allows Default .Site.Params.showAllPostsArchive jasonrogena/hugo-theme-cactus
1 participant
@jasonrogena