Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not concat, use bl #6

Open
mcollina opened this issue Dec 16, 2014 · 2 comments
Open

Do not concat, use bl #6

mcollina opened this issue Dec 16, 2014 · 2 comments

Comments

@mcollina
Copy link

Buffer.concat is slow, as it allocates a completely new Buffer for each pass. I think you should use bl.
@wez wez mentioned this issue Jun 21, 2015
Closed
@mattcollier
Copy link

@mcollina how's this look? master...digitalbazaar:db

@mcollina
Copy link
Author

mcollina commented Sep 5, 2018

Ok for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mcollina @mattcollier