Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Where to put convert class #26

Closed
heisenbuug opened this issue Aug 4, 2020 · 6 comments
Closed

Where to put convert class #26

heisenbuug opened this issue Aug 4, 2020 · 6 comments

Comments

@heisenbuug
Copy link

heisenbuug commented Aug 4, 2020

I have implemented a Convert class as per the requirement of the issue
In which directory should we put this new code?
Link to my implementation.
Once decided I can make a PR accordingly.

@kartikdutt18
Copy link
Member

Hey @heisenbuug, Sorry for the late reply. I'm completely forgot about this. What do you thing about having a separate directory like dataset_utils or something.

@heisenbuug
Copy link
Author

Hey @kartikdutt18 , it's fine. Yea...I think it would totally make sense to do that...I will make a PR accordingly .

@mlpack-bot
Copy link

mlpack-bot bot commented Sep 11, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Sep 11, 2020
@mlpack-bot
Copy link

mlpack-bot bot commented Oct 11, 2020

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@shrit
Copy link
Member

shrit commented Oct 11, 2020

@kartikdutt18 Do you need to keep this one open? Thanks

@mlpack-bot mlpack-bot bot removed the s: stale label Oct 11, 2020
@heisenbuug heisenbuug reopened this Oct 11, 2020
@heisenbuug
Copy link
Author

No, we don't need this one open. Sorry for not updating,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants