-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where to put convert class #26
Comments
Hey @heisenbuug, Sorry for the late reply. I'm completely forgot about this. What do you thing about having a separate directory like dataset_utils or something. |
Hey @kartikdutt18 , it's fine. Yea...I think it would totally make sense to do that...I will make a PR accordingly . |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍 |
@kartikdutt18 Do you need to keep this one open? Thanks |
No, we don't need this one open. Sorry for not updating, |
I have implemented a Convert class as per the requirement of the issue
In which directory should we put this new code?
Link to my implementation.
Once decided I can make a PR accordingly.
The text was updated successfully, but these errors were encountered: