Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that the include files are copied everytime make is written. #14

Open
toshal-a opened this issue Aug 5, 2020 · 2 comments
Open
Labels
build system help wanted Extra attention is needed

Comments

@toshal-a
Copy link
Collaborator

toshal-a commented Aug 5, 2020

While reviewing a PR I noticed a bug.

Whenever a user hits make two times consecutively while building the repository, if there is any change in the include directory, the given change is not reflected and make does not build that change. The reason might be because the build/include once created by copying the include folder, then the changes are not reflected.

Steps to Reproduce

mkdir build && cd ./build
cmake ../
make 
Then make some changes in any file (For example, in `summary_writer_impl.hpp` change the method name.)
make

Actual Behaviour

The changes made in summary_writer_impl.hpp are not getting reflected while building and the build compiles as normal.

Expected Behaviour

The changes should get reflected.

@toshal-a toshal-a added build system help wanted Extra attention is needed labels Aug 5, 2020
@jeffin143
Copy link
Member

After making changes hit cmake again and then hit make , it will work

@jeffin143
Copy link
Member

Currently the include dir is only build , so if we want to replicate what is done in mlpack the include dir should be ../include and then the changes would be reflected when you hit make

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants