Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for Adding New Examples to mlpack's Example Zoo #220

Closed
sitamgithub-MSIT opened this issue Feb 25, 2024 · 12 comments
Closed

Proposal for Adding New Examples to mlpack's Example Zoo #220

sitamgithub-MSIT opened this issue Feb 25, 2024 · 12 comments

Comments

@sitamgithub-MSIT
Copy link

Objective

The objective of this proposal is to enhance mlpack's example repository by adding new examples that demonstrate the application of various machine learning algorithms across diverse real-world domains, as explained here.

Proposed Deliverables

This aims to add new examples to mlpack's repository, provide detailed documentation, integrate visualizations, and ensure regular updates and maintenance to ensure compatibility with the latest versions of mlpack and related dependencies.

Example Ideas

These examples demonstrate the potential of mlpack in various tasks, such as image recognition and others.

cc: @zoq

@sitamgithub-MSIT
Copy link
Author

I went through the mentioned tickets. What I got from those was:

#154 In this issue, it is proposed to put examples in their respective folders, like this:

lstm_electricity_consumption/
|- .
|- ..
|- Jupyter_notebook_code/   <-- code relative to Jupyter notebook
|- C++/    <-- code relative to C++, Makefiles, etc.
|- Go/     <-- similar thing here
|- Python/
|- etc/   <-- other language binding 
README.md <-- this will explain what is happening inside this folder.

One pull request already mentioned with respect to this issue here

#113 Here it is proposed to give an example using YOLOv1, and the issue says to first implement YOLOv3 and PR get merged, and then we can make an example after that.

@sitamgithub-MSIT
Copy link
Author

Though I want to go ahead with making examples and, if required, also helping in implementing YOLOv3 later.

@zoq
Copy link
Member

zoq commented Feb 27, 2024

#154 as you already mentioned is about restructuring the repository, and is more about the build pipeline to make sure each example builds as expected, #191 is a very good basis.

@zoq
Copy link
Member

zoq commented Feb 27, 2024

We can provide an example for YOLOv1, no need to wait for an implementation of v3, but nevertheless, would be great to have for sure.

@sitamgithub-MSIT
Copy link
Author

For YOLOv1, I had read the issue, but I would like to spend a little time researching and then coming up with my proposal. For the file structure referring to issue #191, hopefully we will raise an initial PR soon.

cc: @zoq

@zoq
Copy link
Member

zoq commented Feb 27, 2024

Sounds good, let me know if there is anything that needs clarification.

@sitamgithub-MSIT
Copy link
Author

Sounds good, let me know if there is anything that needs clarification.

Currently, I am referring to PR #191 for my initial work. Moving different files or notebooks to their corresponding folders or updating the readme should not be a problem. Handling the makefile and others is something I am particularly interested in. Btw, these are the initial things I observed when revising the PR, so I can be wrong as well. After a thorough review of the PR, things will be more clear.

@sitamgithub-MSIT
Copy link
Author

Btw @zoq this should be the folder structure right!?

lstm_electricity_consumption/
|- .
|- ..
|- Jupyter_notebook_code/   <-- code relative to Jupyter notebook
|- C++/    <-- code relative to C++, Makefiles, etc.
|- Go/     <-- similar thing here
|- Python/7
|- etc/   <-- other language binding 
README.md <-- this will explain what is happening inside this folder.

@shrit
Copy link
Member

shrit commented Feb 28, 2024

@sitamgithub-MSIT keep in mind that all of the current examples are pure Jupyter Notebook which is only handy when needed. I think we should export C++ examples for each one of these examples.
Originally this repo used to have C++ examples, now it looks more like Jupyter Notebook examples, it would be nice to have some pure C++ examples as well.

@shrit
Copy link
Member

shrit commented Feb 28, 2024

etc/ does not make much sense, if it is a Julia example, then you put it in a Julia directory. There is no need to have exactly the same directories in each one of the examples.

@Shay2Shay
Copy link

I wanted to contribute into Example Zoo. I just wanted to know does MlPack provide Learnable Parameters as Pytorch do?
(Learnable Parameter = any tensor / matrix / array which can be adjusted via gradient descent).

Copy link

mlpack-bot bot commented Apr 21, 2024

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Apr 21, 2024
@mlpack-bot mlpack-bot bot closed this as completed Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants