Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website appears to be missing many JS files #144

Open
rw opened this issue Dec 28, 2019 · 8 comments
Open

Website appears to be missing many JS files #144

rw opened this issue Dec 28, 2019 · 8 comments
Labels

Comments

@rw
Copy link

rw commented Dec 28, 2019

The homepage appears to be missing many files required for the rendering of benchmarks.

Example 404s as of December 28, 2019:

https://www.mlpack.org/js/benchmarks/historical-comparison-view.js
https://www.mlpack.org/css/d3-style.css

Related: is there a way to use the benchmark suite without Javascript? Perhaps just show all the results in a big page?

@zoq
Copy link
Member

zoq commented Dec 28, 2019

Right, I'm working on a redesign, we could provide an sql dump, if that is something you find helpful.

@zoq zoq added the question label Dec 28, 2019
@rw
Copy link
Author

rw commented Dec 28, 2019

@zoq Ah, okay, well, the site is basically down for the time being :-] Maybe we can put up an archived version?

@rw
Copy link
Author

rw commented Dec 28, 2019

@zoq Also, I tried multiple browsers and settings, trying to get it to work. Maybe a friendly note at the top of the page would be helpful to save people time?

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2019

We can easily push the relevant files to the mlpack.org repo so it temporarily works. @zoq what do you think? I could do that pretty quickly.

@zoq
Copy link
Member

zoq commented Dec 29, 2019

@rw Sorry for the inconvenience, I'm certain we can update the page in the next days.

@rcurtin if we can put this together quickly, I think that is a good solution.

@rcurtin
Copy link
Member

rcurtin commented Dec 29, 2019

@zoq done, but I think the db I pushed is pretty out of date. If you have a newer version and want to push that to the repository I'll keep my eyes open for a commit email and then rebuild the site.

It doesn't match the new site and it doesn't look great but it's at least functional until we get something better in place. :)

@zoq
Copy link
Member

zoq commented Dec 30, 2019

Thanks for the quick update, let's see if I can find a newer database.

@rw
Copy link
Author

rw commented Dec 31, 2019

Progress! I see some interactivity now, but no charts. The "parameters" box is unpopulated, and there is a JS error:

Uncaught TypeError: Cannot read property 'values' of undefined
    at Object.rc.orderSelect (runtime-comparison-view.js:222)
    at HTMLSelectElement.onchange (benchmark.html:1)

This is for:
Compare library runtimes for an algorithm/parameter combination
LSH
instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants