-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GNN] Reference implementation for GNN node classification #700
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
recheck |
gnn_node_classification/README.md
Outdated
pip install torch==1.13.0+cu117 torchvision==0.14.0+cu117 torchaudio==0.13.0 --extra-index-url https://download.pytorch.org/whl/cu117 | ||
pip install torch_geometric | ||
pip install --no-index torch_scatter torch_sparse -f https://data.pyg.org/whl/torch-1.13.0+cu117.html | ||
pip install graphlearn-torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have a library version pinned here so that we can reproduce the exact results even after a few months / years? This would also apply for all other libraries, such as torch_geometric
in line 14.
Additionally, it would be very helpful for users if we can integrate these into a Dockerfile, so that all they need to do is to run docker build -f Dockerfile .
instead of manually following all the steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added guidelines for building Docker image using the Dockerfile
…kerfile, refine the evaluation frequency and thoroughness
parser.add_argument("--random_seed", type=int, default='42') | ||
parser.add_argument('--num_classes', type=int, default=2983, | ||
choices=[19, 2983], help='number of classes') | ||
parser.add_argument("--validation_frac", type=float, default=0.025, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor correction: the validation fraction should be set as 0.005 -
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the correction!
Is it possible to also update the file name from |
The folder is renamed as |
As discussed in the MLLogging PR, could we also add gradient accumulation step (1 in our current case) and optimizer name (Adam in our case) to MLLog outputs? |
… log outputs Committed-by: LiSu from Dev container
Added gradient accumulation step and optimizer name to MLLog outputs ;-) |
Just noticed that the checker is asking for |
Fixed in the last commit. |
In this PR we (Alibaba, Intel & Nvidia) propose a GNN training benchmark, which is a multi-class node classification task in a heterogenous graph using the IGB Heterogeneous Dataset named IGBH-Full. The task is carried out using a GAT model based on the Relational Graph Attention Networks paper.