Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguating execution modes #1838

Open
rajesh-s opened this issue Aug 27, 2024 · 1 comment
Open

Disambiguating execution modes #1838

rajesh-s opened this issue Aug 27, 2024 · 1 comment

Comments

@rajesh-s
Copy link

rajesh-s commented Aug 27, 2024

What are the difference between the test and valid modes list on the documentation?

Since this is intended to be a reproducible bechmark suite, would it be possible to add clear instructions on which modes are to be run and the impact each step has? For instance, I cannot tell if the test execution mode is optional or if it is generating a target metric (as indicated by "record the estimated offline_target_qps" on the documentation)

@arjunsuresh
Copy link
Contributor

Valid execution mode tries to do a valid run meeting the minimum duration of 10 minutes. But for this it relies on the user provided qps value in offline and server scenarios.

Test execution mode is just for testing (in the documentation it serves to launch the container too). But it also helps in determining the qps for the valid run. If user knows the qps, there's no need to do the test run.

We'll add these in the documentation. Please keep this issue open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants