Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderGraph Conversion #263

Open
ChrisTsiamitas opened this issue Aug 27, 2024 · 1 comment
Open

ShaderGraph Conversion #263

ChrisTsiamitas opened this issue Aug 27, 2024 · 1 comment

Comments

@ChrisTsiamitas
Copy link

Are there any plans on converting the DirectVolumeRendering Shader to ShaderGraph shader? If not, how would you go and do it? Thank you in advance!

@mlavik1
Copy link
Owner

mlavik1 commented Aug 28, 2024

Hi @ChrisTsiamitas , Good question!
There are no plans to move the shaders to ShaderGraph. Personally I think it would be harder to work with visual shaders for volume rendering. I see a lot of benefit of using ShaderGraph for shaders that interact heavily with Unity's lighting system and depends on Unity-provided shader functionality, but that's not so much the case here. Also, I spend a lot of time profiling with tools like RenderDoc / Nvidia Nsight, so it's more practical to work in a shader language which is not so different form the final shader.

And regarding your second question: I'm not sure what would be the best way to convert it to ShaderGraph, but maybe someone else reading this will be able to give you some suggestions 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants