Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application crashed due to Failed to rename all targeted members, because the references are blocking each other #379

Closed
KvanTTT opened this issue Jul 17, 2021 · 3 comments · Fixed by #425 · May be fixed by #385
Closed
Labels
bug Something isn't working
Milestone

Comments

@KvanTTT
Copy link

KvanTTT commented Jul 17, 2021

  • ConfuserEx Version: 1.6.0-alpha+52bdc4d8a5
  • Target Framework: 4.7.2
  • Operating System: Windows 10

Confuser displays the error during confusing (by yellow color):

Failed to rename all targeted members, because the references are blocking each other

But application crashes with a similar exception (these definitions match definitions from the abovementioned warning message):

System.TypeInitializationException: The type initializer for '_TxP0AsG8nfNdg13bierh6qBfDmUA' threw an exception. ---> System.TypeLoadException: Method '_5eWIIuvnOFv3kKlDFd5OIn0ZamC' in type '_RQbl3JXbfV9R9u8bfHFRVVZD5Kd' from assembly 'Test, Version=2.0.0.0, Culture=neutral, PublicKeyToken=null' does not have an implementation.

This probably happens due to renaming protection with renPublic = true and related to cases when the method in base type implements an interface method for the derived type. shortNames option does not help.

I'll try to extract a minimal code sample later (it's quite complicated because of the big project and intertwined structure).

Is it possible to fix it (it worked in previous versions)? Or similar entities should be excluded from renaming?

@KvanTTT KvanTTT added potential-bug Something does not seem to be working triage This issue needs some initial analysis. labels Jul 17, 2021
@KvanTTT KvanTTT changed the title The error Failed to rename all targeted members, because the references are blocking each other is still presented in the latest version Application crashed due to Failed to rename all targeted members, because the references are blocking each other Jul 17, 2021
KvanTTT added a commit to PositiveTechnologies/ConfuserEx that referenced this issue Jul 25, 2021
@KvanTTT
Copy link
Author

KvanTTT commented Jul 25, 2021

Unfortunately, I was not able to find a minimal sample that covers this issue. But I found out how to fix it, please check the related pull request.

@mkaring mkaring added bug Something isn't working and removed potential-bug Something does not seem to be working triage This issue needs some initial analysis. labels Aug 13, 2021
KvanTTT added a commit to PositiveTechnologies/ConfuserEx that referenced this issue Aug 15, 2021
KvanTTT added a commit to PositiveTechnologies/ConfuserEx that referenced this issue Aug 15, 2021
@KvanTTT
Copy link
Author

KvanTTT commented Aug 15, 2021

It seems like I've found such a sample (see in the attached pull request)!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants