Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sims_maf dependency on ipython-notebook obsolete? #74

Open
rhiannonlynne opened this issue Jul 29, 2016 · 5 comments
Open

sims_maf dependency on ipython-notebook obsolete? #74

rhiannonlynne opened this issue Jul 29, 2016 · 5 comments

Comments

@rhiannonlynne
Copy link
Collaborator

So sims_maf has a dependency on ipython-notebook >= 3.0
(line 104/105 https://github.com/mjuric/conda-lsst/blob/master/etc/config.yaml)

but I believe with jupyter notebook, that the 'ipython-notebook' package is deprecated.

I don't know if we require a specific version of jupyter or ipython, but if it's already a recent enough version, we should just drop the ipython-notebook requirement. I'm not entirely sure where the change happened, but I think it was with ipython 4.0.

@mjuric
Copy link
Owner

mjuric commented Jul 29, 2016

We added the requirement because people were confused when they installed sims_maf and didn't have IPython :).

What would you prefer -- to have them install (ipython|jupyter)-notebook manually, or just bump up the requirement to jupyter-notebook?

@rhiannonlynne
Copy link
Collaborator Author

Is there a jupyter-notebook? (I don't see one if I do conda search jupyter-notebook).
If they have jupyter_core > 4.0, I think that they have jupyter notebook automatically, or anyway, I can't figure out which of the jupyter modules (jupyter, jupyter_core, jupyter_client or jupyter_console) it comes with.

@rhiannonlynne
Copy link
Collaborator Author

rhiannonlynne commented Jul 30, 2016

Does jupyter come with miniconda? If so, I think the easiest thing to do is drop any requirement. If people don't have jupyter or ipython notebook capabilities (because they have a very old version of anaconda/miniconda), they can install it manually. And upgrade conda.

@mjuric
Copy link
Owner

mjuric commented Jul 30, 2016

No, miniconda comes with nothing; that's why we added the requirement.

Fine with me to drop it, but you'll have to update the docs to make sure people know to install it on their own.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

On July 29, 2016 5:02:57 PM PDT, Lynne Jones [email protected] wrote:

Does jupyter come with miniconda? If so, I think the easiest thing to
do is drop any requirement. If people don't have jupyter or ipython
notebook capabilities, they can install it manually.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#74 (comment)

@rhiannonlynne
Copy link
Collaborator Author

Hmm. Maybe we can add the relevant 'jupyter' to the dependencies?

On Fri, Jul 29, 2016 at 5:12 PM Mario Juric [email protected]
wrote:

No, miniconda comes with nothing; that's why we added the requirement.

Fine with me to drop it, but you'll have to update the docs to make sure

people know to install it on their own.

Sent from my Android device with K-9 Mail. Please excuse my brevity.

On July 29, 2016 5:02:57 PM PDT, Lynne Jones [email protected]
wrote:

Does jupyter come with miniconda? If so, I think the easiest thing to
do is drop any requirement. If people don't have jupyter or ipython
notebook capabilities, they can install it manually.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#74 (comment)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#74 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABxQ3xCzALUkGFhDantYdtXRckmkTJcZks5qapb0gaJpZM4JYpFS
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants