Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different default value for format for setting metadata #205

Open
vladimirr9 opened this issue Mar 21, 2022 · 2 comments
Open

Different default value for format for setting metadata #205

vladimirr9 opened this issue Mar 21, 2022 · 2 comments

Comments

@vladimirr9
Copy link

When we look at the two methods for setting image metadata
public void setImageMeta(File image, Map<? extends Tag, String> tags)
and
public void setImageMeta(File image, ExifToolOptions options, Map<? extends Tag, String> tags) throws IOException
The first one assumes the format to be numeric, while with the second the default builder value is human_readable, not sure if this is intended, but it took me quite some time debugging and I thought I'd bring it to your attention.

@mjeanroy
Copy link
Owner

mjeanroy commented Apr 7, 2022

Thanks for the report @vladimirr9 !

not sure if this is intended

No, it's not, and you're 100% right, it's quite misleading.
I fear that it would be hard to change it now as it would be a breaking change.

Do you have any suggestion?
What could have help you that could help the next one? Maybe updating the README explaining the difference?

@vladimirr9
Copy link
Author

If it can't outright be fixed, I think the best way to go about it would perhaps be updating the documentation comments or perhaps an example in the readme highlighting the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants