Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If file path contains spaces and stayOpen is enabled, exiftool fails to read meta on Windows #15

Open
valnaumov opened this issue Mar 15, 2018 · 7 comments

Comments

@valnaumov
Copy link

Although works for Mac.

@valnaumov valnaumov changed the title If file path contains spaces and stayOpen enable, exiftool fails to read meta on Windows If file path contains spaces and stayOpen is enabled, exiftool fails to read meta on Windows Mar 15, 2018
@mjeanroy
Copy link
Owner

Hi,
Thanks for the report.
Does it work without stayOpen?

@valnaumov
Copy link
Author

@mjeanroy

Hi. Yes, it does work without stayOpen

@mjeanroy
Copy link
Owner

Hi @valnaumov,

I just added a unit test with a file containing a space (see 09a4db97), and it seems to work (on Windows and Unix). What versions of exiftool are you using? Can you give me the name of a file that does not work? Does it contains anything special, except spaces?

@valnaumov
Copy link
Author

valnaumov commented Mar 28, 2018

@mjeanroy

Pardon me, it appears that it was not the space that caused the issue, it were cyrillic characters as part of the name. The name was something like: d:\temp\по-русски.CR2.

Guess we can't do anything about it?

@mjeanroy
Copy link
Owner

Thanks, I'll try to look at that but I think the problem is with exiftool, not with this wrapper. Nevertheless, if a file name contains non-supported characters, we should be able to print, at least, a warning, what do you think ?

@valnaumov
Copy link
Author

@mjeanroy I'd prefer an exception, if we can be certain that in given circumstances non-ASCII symbols won't work. One may work with exiftool for months, and he would not note such a pitfall like it happened to myself. The more explicit, the better, I think.

@mjeanroy
Copy link
Owner

mjeanroy commented Apr 3, 2018

@valnaumov I searched in exfitool forum about encoding issue, and it looks like this is your problem: http://u88.n24.queensu.ca/exiftool/forum/index.php/topic,4029.msg18896.html#msg18896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants