Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement libdjinterop : Change menu option name (more generic / less confusing) #14141

Open
audministrator opened this issue Jan 8, 2025 · 6 comments

Comments

@audministrator
Copy link

audministrator commented Jan 8, 2025

Feature Description

It seems that the menu to export to Engine now says Engine Prime
This might be confusing for users who are using a Denon / Numarks controller.

image

Maybe a good idea in the next release to make is more generic.
All Denon / Numark standalone gear these day are running Engine OS embedded software.

Engine Prime to Engine DJ OS

@Swiftb0y
Copy link
Member

Swiftb0y commented Jan 8, 2025

Changing strings is fairly easy. Are you interested in creating a Pull request for that? It would need to be targeted at the main branch.

@audministrator
Copy link
Author

@Swiftb0y Sure no problem, if you could me a hint on how to ?

@audministrator
Copy link
Author

Tried to add the pull request but it failed ?
I am not able to add a pull request to the MAIN branch, so I chose branch 2.5.1

But than I got this error ...

Pull request creation failed. Validation failed: must be a collaborator

@Swiftb0y
Copy link
Member

I'm sorry, I don't know whats wrong. How are you creating the pull request? Can you record a quick screencast?

@audministrator
Copy link
Author

No problem, all new to me ?

I got some more directives from @Eve00000 in the mean time.
She told me that I need to create my onw fork ... was not aware of this.

Will give it a try over the weekend.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants