Use of sanitize_user vs sanitize_title for nicename

[ianbmacdonald]

I was looking at nicenames created by shibboleth and noticed that they were out of sync with one generated directly in wordpress.

I found this thread that notes the use of sanitize_uesr added in v1.4 should have been sanitize_title to avoid the use of certain characters in author permalinks.

A simple fix to update the filter to use the sanitize_title function should be added if the author agrees.

Thread below,

https://wordpress.org/support/topic/plugin-shibboleth-username-at-risk-of-breaking-permalinks-with-author?replies=13

My testing shows 4.1 works fine so far as well.

[jrchamp]

Can you provide a quick example with before and after here so that people in this issue have a bit more clarity? It sounds like the @ and . characters are problematic, but knowing what it gets replaced with and how existing nicenames can be fixed would be helpful. Thanks!

[michaelryanmcneill]

Hello, thank you for reporting this issue. I am the new maintainer of the plugin and all further work on the plugin will be done in a new GitHub repository. Can you please provide the information requested by @jrchamp in the new repository's issue tracker?

[jrchamp]

This should be resolved by michaelryanmcneill/shibboleth#4