Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issue is with loading tiles. #1482

Closed
Mohammadf4f12 opened this issue Nov 11, 2024 · 7 comments
Closed

The issue is with loading tiles. #1482

Mohammadf4f12 opened this issue Nov 11, 2024 · 7 comments
Labels
awaiting answer Additional information is required. Will be closed after 14 days. bug Stale

Comments

@Mohammadf4f12
Copy link

Describe the bug

Sometimes, in the panorama, images from another panorama are displayed!

Online demo URL

No response

Photo Sphere Viewer version

5.8.3

Plugins loaded

No response

OS & browser

All mobile browsers

Additional context

IMG_۲۰۲۴۱۱۱۱_۱۲۵۶۱۸

@mistic100
Copy link
Owner

Cannot help without a proper demo.

@mistic100 mistic100 added awaiting answer Additional information is required. Will be closed after 14 days. missing demo A demo is required. Will be closed after 14 days. labels Nov 11, 2024
Copy link

github-actions bot commented Nov 15, 2024

An isolated working demo is required in order to analyze this issue.
You can easily create a demo on Codepen/JSFiddle/CodeSandBox by clicking the buttons on the top of every example in the documentation.

Why this is important:

  • I do not have the time to reproduce every test case from scratch
  • your bug might be related to your own application and not Photo Sphere Viewer (thus I will be unable to reproduce it)
  • taking the time to create a demo yourself allows to take a step back and find the solution yourself

DO'S and DON'TS:

  • DON'T use minified source files in your demo
  • DON'T share your code inside a ZIP, I will only look at online demos
  • DO isolate the viewer from the rest of the app, if possible
  • DO describe the step-by-step workflow to reproduce the issue

@Mohammadf4f12
Copy link
Author

Hi,
Hope you're having a great day.

I’ve created the demo and sent you the link.
I’ve also attached a video to show you the issue.

As you can see, the tiles occasionally encounter problems.
I’ve checked everything, and the issue is not related to the internet connection as the images download without any problems. The issue is with the library.
(In image 5, for example, the images didn’t display correctly, but after switching between image 4 and image 5 once, the issue was resolved.)

At the end of the video, to ensure the problem isn’t network-related and that the images are indeed downloaded, I opened the undownloaded images to check if they could fix the broken tile. As you noticed, none of those images corresponded to the broken tile.

As a final note, I’d like to mention that this issue occurs much more frequently on mobile devices.
I’ve tested it on both Android and iOS, and the problem persists on both platforms.

Demo:
https://codepen.io/Y7uby7km/pen/QWePVOq?editors=0010

Video:
https://drive.google.com/file/d/16AfSq_F4lc5QGYpcK2fdkTf2NnZPabfm/view?usp=drivesdk

@mistic100
Copy link
Owner

Allright, I can only reproduce it 10% of the time when quickly and erraticaly moving the camera just after changing the current panorama. In a normal operation : clicking an item in the gallery, wait 1-2 seconds for the image to load, then moving the camera, it never happens.

So I don't think I will take time to debug this. If it was reproducible 100% of the time why not, but here it seems to be a very rare edge case only found by QA testers :-)

@mistic100
Copy link
Owner

Also did you try to update the lib ? There was a lot of performance related changes in version 5.11

@mistic100 mistic100 removed the missing demo A demo is required. Will be closed after 14 days. label Nov 17, 2024
@Mohammadf4f12
Copy link
Author

I have used the latest version of the library in the demo. Also, this problem occurs much more in mobile. When using the virtual tour, the user usually moves between images very quickly with markers. As a result, the library creates many logs for the virtual tour

Video:

https://drive.google.com/file/d/16C6N3FUPj5FXFpn5zt3hPJZwQPiLHRAe/view?usp=drivesdk

Copy link

This issue has been automatically marked as stale because not enough information was provided. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 25, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting answer Additional information is required. Will be closed after 14 days. bug Stale
Projects
None yet
Development

No branches or pull requests

2 participants