Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Vue version #193

Open
mirkoperillo opened this issue Jul 5, 2023 · 5 comments
Open

Bump Vue version #193

mirkoperillo opened this issue Jul 5, 2023 · 5 comments
Labels
refactor Maintain a healthy project

Comments

@mirkoperillo
Copy link
Owner

Currently Resting uses Vue.js 2.6.

The final goal is moving to last new stable version of Vue (3.x). Understand what's side-effect and blocking steps of bumping from current version to new one

@mirkoperillo mirkoperillo added the refactor Maintain a healthy project label Jul 5, 2023
@mirkoperillo
Copy link
Owner Author

@nikhilraojl could you be interested in this issue ?

@nikhilraojl
Copy link
Contributor

@mirkoperillo Sure, I will have a go this weekend. Are there any UI elements currently implemented in vue in the current version of the extension?

@mirkoperillo
Copy link
Owner Author

Yes absolutely.
You can find them in src/js/app/components.

A screenshot to give a visual idea where the Vue components are in the UI

Resting - the REST client — Firefox Developer Edition_001

The idea is bumping Vue contained in src/js/vendor to the last stable version and understand if everything continues to work or if there are problems.

I am available for more details or suggestions

@nikhilraojl
Copy link
Contributor

@mirkoperillo It seems we can't just use the existing way i.e

  • bump the vue version to 3.3.4 in package.json
  • build the vue components into umd format through build script
  • import built vue umd components and vue runtime (vue.runtime.global.prod) through requirejs in app.js
  • mount the component

I tried the above with no luck. In vue3 we have to have Vue as global variable for library components and we have to use the new Vue.createApp({}) constructor to create compnents instead of new Vue({}). I have updated both but wasn't able to make it work and always got errors

It seems vue3 and requirejs don't mix well which I am guessing is the issue stackoverflow question

P.S Sorry for the delay was stuck up with some work

@mirkoperillo
Copy link
Owner Author

It seems vue3 and requirejs don't mix well which I am guessing is the issue stackoverflow question

Interesting, so it is not a smooth replacement. I need to investigate about this.

P.S Sorry for the delay was stuck up with some work

Don't worry. I appreciate every time you dedicate to Resting.
Thank you for your initial investigation. It has been useful to understand how to move forward with the roadmap for the project (More details in these notes on my blog)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Maintain a healthy project
Projects
None yet
Development

No branches or pull requests

2 participants